Bug 128655 - VerifyMarked functor is wrong during EdenCollections
Summary: VerifyMarked functor is wrong during EdenCollections
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks: 129067
  Show dependency tree / graph
 
Reported: 2014-02-11 22:12 PST by Mark Hahnenberg
Modified: 2014-02-19 15:25 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-02-11 22:12:20 PST 
We should think about the invariants for the MarkedBlock's BlockState.
Comment 1 Mark Hahnenberg 2014-02-11 22:14:13 PST 
To be more specific, blocks whose marks aren't cleared during an EdenCollection could potentially still be in the Allocated block state. Historically the invariant has been that all blocks after a collection are in the MarkedState. It might be the case that we can relax this invariant for EdenCollections.
Comment 2 Mark Hahnenberg 2014-02-11 22:14:49 PST 
(In reply to comment #1)
> MarkedState
Marked state.
Comment 3 Mark Lam 2014-02-19 15:24:39 PST 
This issue can be easily reproduced by applying the patch at <https://webkit.org/b/129067>, and running testapi on a 64-bit debug build.
Comment 4 Radar WebKit Bug Importer 2014-02-19 15:25:39 PST 
<rdar://problem/16115197>