Bug 12865 - More gdk's notImplemented() macro improvements
Summary: More gdk's notImplemented() macro improvements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-22 22:42 PST by Krzysztof Kowalczyk
Modified: 2007-02-22 23:01 PST (History)
0 users

See Also:

Attachments
improvements to notImplemented() macro usage (16.60 KB, patch)
2007-02-22 22:44 PST, Krzysztof Kowalczyk 		aroben: review+
Details | Formatted Diff | Diff
forgot to set svn:eol-style (16.76 KB, patch)
2007-02-22 22:50 PST, Krzysztof Kowalczyk 		aroben: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Kowalczyk 2007-02-22 22:42:56 PST 
More gdk's notImplemented() macro improvements
Comment 1 Krzysztof Kowalczyk 2007-02-22 22:44:16 PST 
Created attachment 13341 [details]
improvements to notImplemented() macro usage

To avoid code duplication, move notImplementedGdk() macro to a separate header file. Remove existing notImplementedGdk() macros and replace remaining notImplemented() to notImplementedGdk() in gdk code.
Comment 2 Adam Roben (:aroben) 2007-02-22 22:49:50 PST 
Comment on attachment 13341 [details]
improvements to notImplemented() macro usage

Index: WebCore/platform/gdk/NotImplementedGdk.h

   You should set svn:eol-style native on this new file.

   r=me
Comment 3 Krzysztof Kowalczyk 2007-02-22 22:50:00 PST 
Created attachment 13342 [details]
forgot to set svn:eol-style

Like before but with svn:eol-style set to native for newly added file.
Comment 4 Adam Roben (:aroben) 2007-02-22 22:51:54 PST 
Comment on attachment 13342 [details]
forgot to set svn:eol-style

Haha, you read my mind. r=me again!
Comment 5 Krzysztof Kowalczyk 2007-02-22 23:01:37 PST 
landed in r19822