Bug 128635 - Inserting a node with a codeOrigin "like" another node should copy both the codeOrigin and codeOriginForExitTarget
Summary: Inserting a node with a codeOrigin "like" another node should copy both the c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 125433
  Show dependency tree / graph
 
Reported: 2014-02-11 16:42 PST by Filip Pizlo
Modified: 2014-02-11 21:49 PST (History)
11 users (show)

See Also:

Attachments
work in progress (70.67 KB, patch)
2014-02-11 17:45 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
more! (163.45 KB, patch)
2014-02-11 18:34 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (185.89 KB, patch)
2014-02-11 18:45 PST, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-02-11 16:42:26 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2014-02-11 16:43:20 PST 
I suspect that the best way to do this is to have the Node constructor somehow take both codeOrigins, so if you really want to copy the codeOrigin from one node as both the codeOrigin and codeOriginForExitTarget, then you have to say that explicitly.
Comment 2 Filip Pizlo 2014-02-11 17:45:28 PST 
Created attachment 223924 [details]
work in progress
Comment 3 Filip Pizlo 2014-02-11 18:34:50 PST 
Created attachment 223926 [details]
more!
Comment 4 Filip Pizlo 2014-02-11 18:45:08 PST 
Created attachment 223927 [details]
the patch
Comment 5 WebKit Commit Bot 2014-02-11 18:47:14 PST 
Attachment 223927 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGGraph.cpp:349:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Michael Saboff 2014-02-11 20:53:16 PST 
Comment on attachment 223927 [details]
the patch

r=me.
Comment 7 Filip Pizlo 2014-02-11 21:38:07 PST 
Landed in http://trac.webkit.org/changeset/163946
Comment 8 Filip Pizlo 2014-02-11 21:48:11 PST 
I broke the debug build.  Fix on the way.
Comment 9 Ryosuke Niwa 2014-02-11 21:49:37 PST 
Fixed debug build in http://trac.webkit.org/changeset/163948.