Bug 128633 – Web Replay: capture and replay nondeterminism of Date.now() and Math.random()

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Blaze Burg]

These are the only sources of nondeterminism implemented in JSC that are visible to script (excluding VM bugs, etc).

For Math.random(), the seed given to WeakRandom can be memoized. For Date.now() and new Date(), we have to memoize each call.

[Blaze Burg]

Created attachment 223920 [details]
patch

[Filip Pizlo]

Comment on attachment 223920 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223920&action=review

R=me but please consider encapsulating the #if ENABLE(WEB_REPLAY) inside a clever macro.

> Source/JavaScriptCore/runtime/DateConstructor.cpp:128
> +#if ENABLE(WEB_REPLAY)
> +        value = deterministicCurrentTime(globalObject);
> +#else
>          value = jsCurrentTime();
> +#endif

Can't you have a macro like REPLAY(jsCurrentTime(), deterministicCurrentTime(globalObject))?

The reason why I would like that more is that #if's can often disturb our ability to visualize the nesting of control flow.  The definition of REPLAY would literally be:

#if ENABLE(WEB_REPLAY)
#define REPLAY(a, b) (b)
#else
#define REPLAY(a, b) (a)
#endif

You can call REPLAY() whatever you like...

> Source/JavaScriptCore/runtime/DateConstructor.cpp:214
> +#if ENABLE(WEB_REPLAY)
> +    return JSValue::encode(jsNumber(deterministicCurrentTime(exec->lexicalGlobalObject())));
> +#else
> +    UNUSED_PARAM(exec);
>      return JSValue::encode(jsNumber(jsCurrentTime()));
> +#endif

Another fine example of a place where that REPLAY() macro would simplify things.

[Blaze Burg]

Comment on attachment 223920 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223920&action=review

>> Source/JavaScriptCore/runtime/DateConstructor.cpp:128
>> +#endif
> 
> Can't you have a macro like REPLAY(jsCurrentTime(), deterministicCurrentTime(globalObject))?
> 
> The reason why I would like that more is that #if's can often disturb our ability to visualize the nesting of control flow.  The definition of REPLAY would literally be:
> 
> #if ENABLE(WEB_REPLAY)
> #define REPLAY(a, b) (b)
> #else
> #define REPLAY(a, b) (a)
> #endif
> 
> You can call REPLAY() whatever you like...

Sure thing, I can add that. It will only help out in cases where the difference is which function to call, but that's fine. (Most replay-oriented hooks add a branch without interleaving the normal code path.)

[Joseph Pecoraro]

Comment on attachment 223920 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223920&action=review

> Source/JavaScriptCore/runtime/DateConstructor.cpp:88
> +    if (cursor.isCapturing())
> +        cursor.appendInput<GetCurrentTime>(currentTime);
> +
> +    if (cursor.isReplaying()) {

If a cursor cannot be both capturing and replaying then this can be an "else if" instead of another if. Or the states could move to an enum (Default, Capturing, Replaying).

> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:793
> +    if (cursor.isCapturing())
> +        cursor.appendInput<SetRandomSeed>(m_weakRandom.seedUnsafe());
> +
> +    if (cursor.isReplaying()) {

Ditto

[Blaze Burg]

Committed r164007: <http://trac.webkit.org/changeset/164007>