Bug 128619 - Web Inspector: DataGrid should support editing tables with arbitrary columns
Summary: Web Inspector: DataGrid should support editing tables with arbitrary columns
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-11 13:28 PST by BJ Burg
Modified: 2014-02-13 13:33 PST (History)
5 users (show)

See Also:

Attachments
patch (26.15 KB, patch)
2014-02-11 14:04 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
heavily revised patch (36.56 KB, patch)
2014-02-12 15:18 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2014-02-11 13:28:50 PST 
The current editing and cell advance code has the columns for DOMStorageView hardcoded. We should be using column identifiers and
Comment 1 Radar WebKit Bug Importer 2014-02-11 13:29:18 PST 
<rdar://problem/16040498>
Comment 2 BJ Burg 2014-02-11 14:04:33 PST 
Created attachment 223900 [details]
patch
Comment 3 BJ Burg 2014-02-12 15:18:36 PST 
Created attachment 224015 [details]
heavily revised patch
Comment 4 WebKit Commit Bot 2014-02-13 13:33:05 PST 
Comment on attachment 224015 [details]
heavily revised patch

Clearing flags on attachment: 224015

Committed r164052: <http://trac.webkit.org/changeset/164052>
Comment 5 WebKit Commit Bot 2014-02-13 13:33:07 PST 
All reviewed patches have been landed.  Closing bug.