Bug 128618 - check-for-webkit-framework-include-consistency script fails if header contains unicode
Summary: check-for-webkit-framework-include-consistency script fails if header contain...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-11 13:22 PST by Anders Carlsson
Modified: 2014-02-11 14:07 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-02-11 13:22:29 PST 
If a header contains a unicode character (like – or “ or ” for example), check-for-webkit-framework-include-consistency fails :

../../Tools/Scripts/check-for-webkit-framework-include-consistency:93:in `match': invalid byte sequence in US-ASCII (ArgumentError)
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:93:in `block (2 levels) in verify_includes'
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:92:in `each_line'
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:92:in `block in verify_includes'
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:91:in `open'
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:91:in `verify_includes'
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:105:in `block (2 levels) in <main>'
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:104:in `each'
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:104:in `block in <main>'
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:102:in `each'
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:102:in `<main>'