Bug 128616 - position:-webkit-sticky is not preserved across a copy
Summary: position:-webkit-sticky is not preserved across a copy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-11 12:27 PST by Myles C. Maxfield
Modified: 2014-02-17 16:04 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-02-11 12:27:56 PST 
Right now we don't copy position:-webkit-sticky. This is because:
1. When copying styled elements, we parse the style properties again
2. CSSParserContext has a flag which can disable parsing -webkit-sticky
3. There are two constructors to CSSParserContext: one that takes a document and sets up the aforementioned flag, and a simple one that doesn't take a document and sets all the enableFoo flags to false
4. At the relevant place within copy code, we are far removed from the Document object, so we instead call the second constructor, thereby disabling parsing of -webkit-sticky
Comment 1 Radar WebKit Bug Importer 2014-02-11 12:31:21 PST 
<rdar://problem/16039902>
Comment 2 Myles C. Maxfield 2014-02-11 12:32:19 PST 
CSSParser::parseValue(MutableStyleProperties* declaration, CSSPropertyID propertyID, const String& string, bool important, CSSParserMode cssParserMode, StyleSheetContents* contextStyleSheet)
Comment 3 Myles C. Maxfield 2014-02-11 16:08:04 PST 
It would be a good idea to simply get rid of this runtime flag altogether.
Comment 4 Myles C. Maxfield 2014-02-17 16:04:59 PST 
The flag is gone. This is solved.