Bug 128614 - [New Multicolumn] getClientRects returns wrong rectangle
Summary: [New Multicolumn] getClientRects returns wrong rectangle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-11 11:22 PST by Dave Hyatt
Modified: 2014-03-20 13:27 PDT (History)
5 users (show)

See Also:

Attachments
Patch (70.39 KB, patch)
2014-02-11 11:24 PST, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (110.51 KB, patch)
2014-02-11 13:20 PST, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (109.18 KB, patch)
2014-02-11 13:23 PST, Dave Hyatt 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2014-02-11 11:22:12 PST 
Make sure getClientRects is as good as the old multicolumn code. The old code returned the column that contained the center point of the content, so that's what we do. Eventually we should return multiple rectangles, but for now this at least gives us parity with the region code and the old multicolumn code.
Comment 1 Dave Hyatt 2014-02-11 11:24:27 PST 
Created attachment 223884 [details]
Patch
Comment 2 Dave Hyatt 2014-02-11 13:20:44 PST 
Created attachment 223892 [details]
Patch
Comment 3 Dave Hyatt 2014-02-11 13:23:06 PST 
Created attachment 223893 [details]
Patch
Comment 4 Sam Weinig 2014-02-11 13:27:57 PST 
Comment on attachment 223893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223893&action=review

> Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:180
> +        return 0;

We have been switching to nullptr in cases like this.

> Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:192
> +        return 0;

We have been switching to nullptr in cases like this.
Comment 5 Dave Hyatt 2014-03-20 13:27:13 PDT 
Fixed in r165991.