Created attachment 223845 [details] Be sure to #include <libgen.h> for basename Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp uses basename() but does not #include <libgen.h> according to POSIX, this is the correct header to use (and even the Linux manpages agree): http://pubs.opengroup.org/onlinepubs/007908775/xsh/libgen.h.html
Same issue on OpenBSD, fixed by http://www.openbsd.org/cgi-bin/cvsweb/ports/www/webkit/patches/patch-Source_WebKit2_PluginProcess_unix_PluginProcessMainUnix_cpp?rev=1.1 Dunno if the #include has to be os-specific...
The header is POSIX-specified, so it should definitely not be made OS-specific.
Comment on attachment 223845 [details] Be sure to #include <libgen.h> for basename Please add a ChangeLog, as described at <http://www.webkit.org/coding/contributing.html>. Either you or someone else has to make a ChangeLog entry for landing.
Created attachment 225088 [details] Patch
(In reply to comment #4) > Created an attachment (id=225088) [details] > Patch Yeah, thinks looks good, thanks a lot!
Created attachment 225359 [details] Patch
Comment on attachment 225359 [details] Patch Clearing flags on attachment: 225359 Committed r164797: <http://trac.webkit.org/changeset/164797>
All reviewed patches have been landed. Closing bug.