Bug 128582 - Stop using PLATFORM(MAC) in WebKit2/Shared except where it means “OS X but not iOS”
Summary: Stop using PLATFORM(MAC) in WebKit2/Shared except where it means “OS X but no...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-10 23:15 PST by mitz
Modified: 2014-02-11 09:56 PST (History)
1 user (show)

See Also:


Attachments
Replace PLATFORM(MAC) (92.92 KB, patch)
2014-02-10 23:28 PST, mitz
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-02-10 23:15:58 PST
Same deal as bug 128513.
Comment 1 mitz 2014-02-10 23:28:31 PST
Created attachment 223815 [details]
Replace PLATFORM(MAC)
Comment 2 Darin Adler 2014-02-11 09:31:40 PST
Comment on attachment 223815 [details]
Replace PLATFORM(MAC)

View in context: https://bugs.webkit.org/attachment.cgi?id=223815&action=review

> Source/WebKit2/Shared/NativeWebKeyboardEvent.h:47
> +#if PLATFORM(GTK)
>  #include <WebCore/CompositionResults.h>
>  #include <WebCore/GUniquePtrGtk.h>
>  #include <WebCore/GtkInputMethodFilter.h>
>  typedef union _GdkEvent GdkEvent;
> -#elif PLATFORM(EFL)
> +#endif
> +
> +#if PLATFORM(EFL)
>  #include <Evas.h>
>  #endif

I would put EFL before GTK because I like alphabetical order rather than arbitrary order for such things.
Comment 3 mitz 2014-02-11 09:56:00 PST
Committed <http://trac.webkit.org/r163886>.