Bug 128581 - IDB: storage/indexeddb/mozilla/cursor-update-updates-indexes.html ASSERTs
Summary: IDB: storage/indexeddb/mozilla/cursor-update-updates-indexes.html ASSERTs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-10 22:20 PST by Brady Eidson
Modified: 2014-02-11 08:22 PST (History)
6 users (show)

See Also:

Attachments
Patch v1 (3.56 KB, patch)
2014-02-10 22:36 PST, Brady Eidson 		ap: review+
Details | Formatted Diff | Diff
Patch for landing (3.05 KB, patch)
2014-02-11 07:44 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-02-10 22:20:33 PST 
IDB: storage/indexeddb/mozilla/cursor-update-updates-indexes.html ASSERTs

Index gets don't return the key path, triggering this assert.  Simple fix.
Comment 1 Radar WebKit Bug Importer 2014-02-10 22:21:07 PST 
<rdar://problem/16034112>
Comment 2 Brady Eidson 2014-02-10 22:36:58 PST 
Created attachment 223811 [details]
Patch v1
Comment 3 Alexey Proskuryakov 2014-02-10 23:00:41 PST 
Comment on attachment 223811 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=223811&action=review

> Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:936
> +    // We must return it to know how to inject the result key into the result value object.

s/it/a key path/
Comment 4 Brady Eidson 2014-02-11 07:44:16 PST 
Created attachment 223862 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2014-02-11 08:22:45 PST 
Comment on attachment 223862 [details]
Patch for landing

Clearing flags on attachment: 223862

Committed r163877: <http://trac.webkit.org/changeset/163877>
Comment 6 WebKit Commit Bot 2014-02-11 08:22:48 PST 
All reviewed patches have been landed.  Closing bug.