Bug 128573 - messages.py doesn't handle parameters with more than one level of scope.
Summary: messages.py doesn't handle parameters with more than one level of scope.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords:
Depends on:
Blocks: 128564
  Show dependency tree / graph
 
Reported: 2014-02-10 19:02 PST by Jeremy Jones
Modified: 2014-02-15 01:22 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.37 KB, patch)
2014-02-10 19:05 PST, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Patch (9.61 KB, patch)
2014-02-11 11:57 PST, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2014-02-10 19:02:20 PST 
messages.py failed if you have a message like:

SetVideoLayerID(WebCore::GraphicsLayer::PlatformLayerID videoLayerID)

It fails generating a header because there are too many parameters to the sting formatting operator:

            headers.append('<%s/%s.h>' % tuple(split))

Where split is (WebCore, GraphicsLayer, PlatformLayerID)
Comment 1 Jeremy Jones 2014-02-10 19:05:14 PST 
Created attachment 223788 [details]
Patch
Comment 2 Jeremy Jones 2014-02-10 21:33:13 PST 
  File "/Volumes/Data/Code/WebKit/OpenSource/Source/WebKit2/Scripts/webkit2/messages.py", line 473, in headers_for_type

TypeError: not all arguments converted during string formatting

    headers.append('<%s/%s.h>' % tuple(split))
Comment 3 Simon Fraser (smfr) 2014-02-10 22:01:39 PST 
Comment on attachment 223788 [details]
Patch

You should probably add a test for this. There are tests in the same directory.
Comment 4 Jeremy Jones 2014-02-11 09:13:41 PST 
(In reply to comment #3)
> (From update of attachment 223788 [details])
> You should probably add a test for this. There are tests in the same directory.

Thanks. I'll do that.
Comment 5 Jeremy Jones 2014-02-11 11:57:11 PST 
Created attachment 223888 [details]
Patch
Comment 6 WebKit Commit Bot 2014-02-15 01:22:53 PST 
Comment on attachment 223888 [details]
Patch

Clearing flags on attachment: 223888

Committed r164171: <http://trac.webkit.org/changeset/164171>
Comment 7 WebKit Commit Bot 2014-02-15 01:22:55 PST 
All reviewed patches have been landed.  Closing bug.