RESOLVED FIXED 128565
[WK2] Add support for image document viewport configuration 
https://bugs.webkit.org/show_bug.cgi?id=128565
Summary [WK2] Add support for image document viewport configuration
Benjamin Poulain
Reported 2014-02-10 16:31:35 PST
[WK2] Add support for image document viewport configuration
Attachments
Patch (5.66 KB, patch)
2014-02-10 16:33 PST, Benjamin Poulain 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-02-10 16:33:16 PST
Created attachment 223768 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-02-10 16:36:51 PST
Comment on attachment 223768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223768&action=review > Source/WebCore/page/ViewportConfiguration.h:87 > + static Parameters imageParameters(); I'd call these textDocumentParamters, imageDocumentParameters. > Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.mm:269 > IntPoint PageClientImpl::screenToWindow(const IntPoint& point) > { > - notImplemented(); > - return IntPoint(); > + return IntPoint([m_view convertPoint:point fromView:nil]); > } > > IntRect PageClientImpl::windowToScreen(const IntRect& rect) > { > - notImplemented(); > - return IntRect(); > + return enclosingIntRect([m_view convertRect:rect toView:nil]); > } Are these changes related to the patch?
Benjamin Poulain
Comment 3 2014-02-10 17:05:37 PST
Committed r163839: <http://trac.webkit.org/changeset/163839>
Note You need to log in before you can comment on or make changes to this bug.