Bug 128560 – Fail FTL compilation if the required stack is too big

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

If the FTL compiles a function with a stack larger than a certain limit (128K has been suggest), fail the compile.

It probably makes sense to make the limit configurable.

[Michael Saboff]

Created attachment 223765 [details]
Patch

[Geoffrey Garen]

Comment on attachment 223765 [details]
Patch

r=me

[Filip Pizlo]

Comment on attachment 223765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223765&action=review

> Source/JavaScriptCore/ftl/FTLStackMaps.h:104
> +    unsigned getStackSize() const;

I would call this stackSize() and not getStackSize().  We don't usually prepend getters with "get".  The reason why "getRecordMap()" has a "get" in it is that it actually has to do significant work to return the record map.  Probably, that should be called "computeRecordMap()".  But your "getStackSize" is not computing anything, and it's a getter, so lets just call it "stackSize()".

[Filip Pizlo]

Comment on attachment 223765 [details]
Patch

r=me but change the name of getStackSize

[Michael Saboff]

(In reply to comment #3)
> (From update of attachment 223765 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223765&action=review
> 
> > Source/JavaScriptCore/ftl/FTLStackMaps.h:104
> > +    unsigned getStackSize() const;
> 
> I would call this stackSize() and not getStackSize().  We don't usually prepend getters with "get".  The reason why "getRecordMap()" has a "get" in it is that it actually has to do significant work to return the record map.  Probably, that should be called "computeRecordMap()".  But your "getStackSize" is not computing anything, and it's a getter, so lets just call it "stackSize()".

Agreed.  I'll change it.

[Michael Saboff]

Committed r163838: <http://trac.webkit.org/changeset/163838>