Bug 128553 – Show a debug tile map indicator for UI-side compositing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Show a debug tile map indicator for UI-side compositing

[Simon Fraser (smfr)]

Created attachment 223749 [details]
Patch

[Tim Horton]

Comment on attachment 223749 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223749&action=review

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:188
> +        // FIXME: get the correct scroll position;

capitals and periods

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:210
> +    m_tileMapHostLayer.get().name = @"Tile map host";

[...] instead of .get() in lots of places

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:221
> +        const CGFloat components[] = { 1, 1, 1, 0.6 };
> +        RetainPtr<CGColorRef> color = adoptCF(CGColorCreate(colorSpace.get(), components));
> +        m_tileMapHostLayer.get().backgroundColor = color.get();

I wonder if using the color cache would be neater.

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.h:51
> +    void setIsDebugLayerTreeHost(bool flag = true) { m_isDebugLayerTreeHost = flag; }

default argument value? weird!

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm:133
> +            layer = adoptNS([[CALayer alloc] init]);

maybe we should give this a background color?

[Simon Fraser (smfr)]

https://trac.webkit.org/r163837