Bug 128548 - Crash in copyShortASCIIString after r163793
Summary: Crash in copyShortASCIIString after r163793
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-10 12:05 PST by Enrica Casucci
Modified: 2014-02-10 15:33 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.29 KB, patch)
2014-02-10 12:06 PST, Enrica Casucci 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2014-02-10 12:05:11 PST 
A null check is missing.
It happens in iOS.
Comment 1 Enrica Casucci 2014-02-10 12:06:34 PST 
Created attachment 223733 [details]
Patch
Comment 2 Alexey Proskuryakov 2014-02-10 12:20:59 PST 
Comment on attachment 223733 [details]
Patch

r=me, however would addressing Darin's FIXME fix this in a better way?

// FIXME: Documentation claims the code above would work on iOS 4.0 and later. After test that works, we should remove this and use that instead.
Comment 3 Enrica Casucci 2014-02-10 13:05:15 PST 
(In reply to comment #2)
> (From update of attachment 223733 [details])
> r=me, however would addressing Darin's FIXME fix this in a better way?
> 
> // FIXME: Documentation claims the code above would work on iOS 4.0 and later. After test that works, we should remove this and use that instead.
I'm not sure about it. The code existed before and was performing a null check.
Comment 4 Alexey Proskuryakov 2014-02-10 15:33:28 PST 
Enrica landed this patch in <http://trac.webkit.org/changeset/163809>.