Bug 128546 - [MSE] Fix layering violations in MediaSource
Summary: [MSE] Fix layering violations in MediaSource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-10 11:43 PST by Jer Noble
Modified: 2014-02-10 15:48 PST (History)
13 users (show)

See Also:

Attachments
Patch (3.40 KB, patch)
2014-02-10 11:58 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (39.28 KB, patch)
2014-02-10 12:01 PST, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-02-10 11:43:59 PST 
[MSE] Fix layering violations in MediaSource
Comment 1 Jer Noble 2014-02-10 11:58:43 PST 
Created attachment 223730 [details]
Patch
Comment 2 Jer Noble 2014-02-10 12:01:16 PST 
Created attachment 223732 [details]
Patch
Comment 3 Eric Carlson 2014-02-10 13:01:17 PST 
Comment on attachment 223732 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223732&action=review

> Source/WebCore/platform/graphics/MediaPlayer.cpp:395
> +bool MediaPlayer::load(const URL& url, const ContentType& contentType, MediaSourcePrivateClient* mediaSource)
>  {
>      m_mediaSource = mediaSource;

Nit: I think it is worth adding an ASSERT because you now take a raw pointer.
Comment 4 Jer Noble 2014-02-10 14:04:39 PST 
Committed r163816: <http://trac.webkit.org/changeset/163816>
Comment 5 Brendan Long 2014-02-10 15:20:03 PST 
This seems to have broken the GTK and EFL builds. Is removing HTMLMediaSource from CMakeLists.txt and GNUMakefile.list.am enough, or do we need to add any new files?
Comment 6 Jer Noble 2014-02-10 15:41:49 PST 
(In reply to comment #5)
> This seems to have broken the GTK and EFL builds. Is removing HTMLMediaSource from CMakeLists.txt and GNUMakefile.list.am enough, or do we need to add any new files?

My apologies.  No, the only new file is a non-exported header only.
Comment 7 Brendan Long 2014-02-10 15:48:04 PST 
No worries, fixed now:

http://trac.webkit.org/changeset/163826
http://trac.webkit.org/changeset/163828