Bug 128520 - Automatically generate isRendererOfType in RENDER_OBJECT_TYPE_CASTS
Summary: Automatically generate isRendererOfType in RENDER_OBJECT_TYPE_CASTS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-10 00:32 PST by Darin Adler
Modified: 2014-02-10 09:53 PST (History)
2 users (show)

See Also:


Attachments
Patch (19.07 KB, patch)
2014-02-10 00:38 PST, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (20.32 KB, patch)
2014-02-10 07:55 PST, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2014-02-10 00:32:52 PST
Automatically generate isRendererOfType in RENDER_OBJECT_TYPE_CASTS
Comment 1 Darin Adler 2014-02-10 00:38:35 PST
Created attachment 223683 [details]
Patch
Comment 2 Darin Adler 2014-02-10 07:55:53 PST
Created attachment 223712 [details]
Patch
Comment 3 Andreas Kling 2014-02-10 09:21:29 PST
Comment on attachment 223712 [details]
Patch

r=me

Though I wish we could templatize the input too, since that would avoid some bit checks when we have RenderElement instead of RenderObject.
Comment 4 WebKit Commit Bot 2014-02-10 09:53:19 PST
Comment on attachment 223712 [details]
Patch

Clearing flags on attachment: 223712

Committed r163793: <http://trac.webkit.org/changeset/163793>
Comment 5 WebKit Commit Bot 2014-02-10 09:53:21 PST
All reviewed patches have been landed.  Closing bug.