Bug 128516 - [WebGL] Remove state restorer code
Summary: [WebGL] Remove state restorer code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-09 21:02 PST by Dean Jackson
Modified: 2014-02-09 21:37 PST (History)
7 users (show)

See Also:

Attachments
Patch (54.21 KB, patch)
2014-02-09 21:08 PST, Dean Jackson 		krit: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-02-09 21:02:00 PST 
I'm not sure what the point of the WebGLStateRestorer class was. It's always constructed with a false parameter, and then isn't even assigned to a local variable so wouldn't have worked anyway. Meanwhile there are also LOTS of calls to cleanupAfterGraphicsCall, the majority of which pass in false, making them a no-op. I replaced the handful of cleanupAfterGraphicsCall(true) with the call to markContextChanged().
Comment 1 Radar WebKit Bug Importer 2014-02-09 21:02:30 PST 
<rdar://problem/16022970>
Comment 2 Dean Jackson 2014-02-09 21:08:32 PST 
Created attachment 223673 [details]
Patch
Comment 3 Dirk Schulze 2014-02-09 21:26:07 PST 
Comment on attachment 223673 [details]
Patch

Looks reasonable and definitely cleaner. r=me
Comment 4 Dean Jackson 2014-02-09 21:37:37 PST 
Committed r163763: <http://trac.webkit.org/changeset/163763>