Bug 128507 - Fix EFL build fallout from bug 128505 by #including Operations.h into those .cpp files that are broken
Summary: Fix EFL build fallout from bug 128505 by #including Operations.h into those ....
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 128505
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-09 16:10 PST by Filip Pizlo
Modified: 2014-02-10 00:53 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-02-09 16:10:19 PST
Operations.h is JSC's umbrella for definitions of inline functions.  If your build fails because an inline function is not defined, just #include Operations.h.

Other workarounds are likely to create long-term problems.  For example, including the specific BlahInlines.h file is harmful because it means that if someone moves any other inline functions out to a *Inlines.h file, they will have to potentially add that include to every .cpp file in the system that may transitively include the place where the inline function was declared.  Alternatively, adding #include "Operations.h" into any other JSC headers is harmful since it risks introducing circular dependencies.  The *whole point* of the *Inlines.h files that Operations.h includes is that they are never included by JSC's interface headers.