WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
128507
Fix EFL build fallout from
bug 128505
by #including Operations.h into those .cpp files that are broken
https://bugs.webkit.org/show_bug.cgi?id=128507
Summary
Fix EFL build fallout from bug 128505 by #including Operations.h into those ....
Filip Pizlo
Reported
2014-02-09 16:10:19 PST
Operations.h is JSC's umbrella for definitions of inline functions. If your build fails because an inline function is not defined, just #include Operations.h. Other workarounds are likely to create long-term problems. For example, including the specific BlahInlines.h file is harmful because it means that if someone moves any other inline functions out to a *Inlines.h file, they will have to potentially add that include to every .cpp file in the system that may transitively include the place where the inline function was declared. Alternatively, adding #include "Operations.h" into any other JSC headers is harmful since it risks introducing circular dependencies. The *whole point* of the *Inlines.h files that Operations.h includes is that they are never included by JSC's interface headers.
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug