Bug 128490 - [iOS][wk2] ASSERT(WebThreadIsCurrent()) in [WebDisplayLinkHandler handleDisplayLink:]
Summary: [iOS][wk2] ASSERT(WebThreadIsCurrent()) in [WebDisplayLinkHandler handleDispl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-08 23:19 PST by Tim Horton
Modified: 2014-02-09 16:21 PST (History)
5 users (show)

See Also:

Attachments
patch (1.47 KB, patch)
2014-02-08 23:21 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-02-08 23:19:14 PST 
[WebDisplayLinkHandler handleDisplayLink:] has an ASSERT(WebThreadIsCurrent()).

We don't use the Web Thread in WebKit2, but it looks to me like isMainThread() does the right thing (main thread if web thread is disabled, web thread otherwise), so let's use that.
Comment 1 Tim Horton 2014-02-08 23:21:47 PST 
Created attachment 223613 [details]
patch

Hopefully someone can clarify if isMainThead does the right thing. And maybe we should audit other callers of WebThreadIsCurrent?
Comment 2 WebKit Commit Bot 2014-02-09 16:21:34 PST 
Comment on attachment 223613 [details]
patch

Clearing flags on attachment: 223613

Committed r163758: <http://trac.webkit.org/changeset/163758>
Comment 3 WebKit Commit Bot 2014-02-09 16:21:37 PST 
All reviewed patches have been landed.  Closing bug.