Bug 128484 - Add the basic infrastructure to compile attributes matching in selectors
Summary: Add the basic infrastructure to compile attributes matching in selectors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-08 20:31 PST by Benjamin Poulain
Modified: 2014-02-10 18:36 PST (History)
12 users (show)

See Also:

Attachments
Patch (57.27 KB, patch)
2014-02-08 20:45 PST, Benjamin Poulain 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-02-08 20:31:30 PST 
Add the basic infrastructure to compile attributes matching in selectors
Comment 1 Benjamin Poulain 2014-02-08 20:45:35 PST 
Created attachment 223604 [details]
Patch
Comment 2 Gavin Barraclough 2014-02-10 17:28:24 PST 
Comment on attachment 223604 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223604&action=review

> Source/WebCore/cssjit/SelectorCompiler.cpp:414
>          }

It looks like the code above here could be simpler if you fully handled the success case above the failure cases? – it would duplicate the restore, but that's a couple of extra loads & it would save a jump.

> Source/WebCore/cssjit/SelectorCompiler.cpp:992
> +    // In general, canonicalLocalName and localName are the same. When they differe, we have to check if the node is HTML to know

differe

> Source/WebCore/dom/Attribute.h:86
> +    return Attribute::nameMatchesFilter(m_name, prefix, localName, namespaceURI);

I don't think you need "Attribute::"?
Comment 3 Benjamin Poulain 2014-02-10 18:36:08 PST 
Committed r163850: <http://trac.webkit.org/changeset/163850>