Bug 128483 - Simplify single character substrings in JSC
Summary: Simplify single character substrings in JSC
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 128491
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-08 19:39 PST by Anders Carlsson
Modified: 2014-02-09 00:13 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.55 KB, patch)
2014-02-08 19:41 PST, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-02-08 19:39:49 PST 
Simplify single character substrings in JSC
Comment 1 Anders Carlsson 2014-02-08 19:41:40 PST 
Created attachment 223601 [details]
Patch
Comment 2 Andreas Kling 2014-02-08 19:43:21 PST 
Comment on attachment 223601 [details]
Patch

Nice ;D
Comment 3 Anders Carlsson 2014-02-08 19:47:01 PST 
Committed r163737: <http://trac.webkit.org/changeset/163737>
Comment 4 Ryosuke Niwa 2014-02-08 23:59:04 PST 
Looks like this patch broke 10 tests:

http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/3233
Comment 5 Ryosuke Niwa 2014-02-09 00:01:48 PST 
e.g.

--- /Volumes/Data/slave/mavericks-release-tests-wk1/build/layout-test-results/fast/lists/w3-css3-list-styles-alphabetic-expected.txt
+++ /Volumes/Data/slave/mavericks-release-tests-wk1/build/layout-test-results/fast/lists/w3-css3-list-styles-alphabetic-actual.txt
@@ -11,82 +11,82 @@
 PASS list marker is በ.
 PASS list marker is ተ.
 PASS list marker is ነ.
-PASS list marker is አ.
-PASS list marker is ከ.
-PASS list marker is ወ.
-PASS list marker is ዐ.
-PASS list marker is የ.
+FAIL list marker should be በ. Was አ.
+FAIL list marker should be ሰ. Was ከ.
+FAIL list marker should be ሐ. Was ወ.
+FAIL list marker should be ለ. Was ዐ.
+FAIL list marker should be ሀ. Was የ.
 PASS list marker is ደ.
 PASS list marker is ገ.
 PASS list marker is ጸ.
 PASS list marker is ፈ.
 ethiopic-halehame-aa-et
Comment 6 WebKit Commit Bot 2014-02-09 00:12:00 PST 
Re-opened since this is blocked by bug 128491
Comment 7 Ryosuke Niwa 2014-02-09 00:13:16 PST 
I'm going to rollout the patch for now since neither kling nor I can spot the error and this is going to hose EWS if we kept it in trunk.