Bug 128464 - Stop using PLATFORM(MAC) in WebCore except where it means “OS X but not iOS”
Summary: Stop using PLATFORM(MAC) in WebCore except where it means “OS X but not iOS”
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-08 11:57 PST by mitz
Modified: 2016-02-19 11:42 PST (History)
4 users (show)

See Also:

Attachments
Replace PLATFORM(MAC) with equivalent alternatives (75.42 KB, patch)
2014-02-08 12:46 PST, mitz 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-02-08 11:57:25 PST 
So that we can make PLATFORM(MAC) false when building for iOS, we need to replace all uses of it that don’t take iOS into account. Most such uses are about building for Cocoa.
Comment 1 mitz 2014-02-08 12:46:40 PST 
Created attachment 223577 [details]
Replace PLATFORM(MAC) with equivalent alternatives
Comment 2 mitz 2014-02-08 14:21:57 PST 
Committed <http://trac.webkit.org/r163725>.
Comment 3 Joseph Pecoraro 2014-02-08 14:38:07 PST 
Nice!
Comment 4 Konstantin Tokarev 2016-02-19 11:42:52 PST 
What was the motivation to use OS(DARWIN) && !PLATFORM(EFL) && !PLATFORM(GTK) in XSLT code instead of simple PLATFORM(COCOA)?