Bug 128457 - Stop using getCharactersWithUpconvert in JavaScriptCore
Summary: Stop using getCharactersWithUpconvert in JavaScriptCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-08 10:17 PST by Anders Carlsson
Modified: 2014-02-08 15:26 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.49 KB, patch)
2014-02-08 10:19 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-02-08 10:17:49 PST 
Stop using getCharactersWithUpconvert in JavaScriptCore
Comment 1 Anders Carlsson 2014-02-08 10:19:47 PST 
Created attachment 223570 [details]
Patch
Comment 2 Andreas Kling 2014-02-08 12:43:21 PST 
Comment on attachment 223570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223570&action=review

Nice! r=me

> Source/WTF/wtf/text/StringView.h:141
> +        if (is8Bit())
> +            return WTF::find(characters8(), length(), character, start);

I wonder if it would be useful to have an early return here if 'character' is outside the LChar range. NABD.
Comment 3 Geoffrey Garen 2014-02-08 13:11:51 PST 
Comment on attachment 223570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223570&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        if the source or replacement strings area 16-bit.

"are"
Comment 4 WebKit Commit Bot 2014-02-08 15:26:39 PST 
Comment on attachment 223570 [details]
Patch

Clearing flags on attachment: 223570

Committed r163727: <http://trac.webkit.org/changeset/163727>
Comment 5 WebKit Commit Bot 2014-02-08 15:26:41 PST 
All reviewed patches have been landed.  Closing bug.