Bug 128454 – ImageDiff compile fails when compiled with libc++

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Rajaram Gaunker]

repro steps: Compile webkit using libc++.

Observation: Following compile errors.

Resolution: include cstdlib in ImageDiff.cpp.

WebKit/Tools/ImageDiff/gtk/ImageDiff.cpp:103:61: error: use of undeclared identifier 'malloc'; did you mean 'g_malloc'?
    unsigned char* diffBuffer = static_cast<unsigned char*>(malloc(width * height));
                                                            ^~~~~~
                                                            g_malloc
webkit_deps/include/glib-2.0/glib/gmem.h:78:10: note: 'g_malloc' declared here
gpointer g_malloc         (gsize         n_bytes) G_GNUC_MALLOC G_GNUC_ALLOC_SIZE(1);
         ^
WebKit/Tools/ImageDiff/gtk/ImageDiff.cpp:147:5: error: use of undeclared identifier 'free'
    free(diffBuffer);
    ^
WebKit/Tools/ImageDiff/gtk/ImageDiff.cpp:207:30: error: use of undeclared identifier 'strtol'
            long imageSize = strtol(tokens[1], 0, 10);
                             ^
3 errors generated.

[Rajaram Gaunker]

Created attachment 223567 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 223567 [details]
Patch

Clearing flags on attachment: 223567

Committed r163711: <http://trac.webkit.org/changeset/163711>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.