Bug 128449 – [GTK] Build break in WebKitWebViewBase.cpp::webkitWebViewBaseCreateWebPage

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Piotr Grad]

context->createWebPage is called with inproper parameter

[Piotr Grad]

Created attachment 223556 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Piotr Grad]

Created attachment 223557 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 223557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223557&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:957
> +    webPageConfiguration.relatedPage = webkitWebViewBaseGetPage(webkitWebViewBase);

This is not correct, you are using the page you are creating as the related page. You should not initialize the related page (it's already null at this point), is currently unimplemented in gtk+ port.

[Piotr Grad]

Created attachment 223559 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 223559 [details]
Patch

Thank you!

[WebKit Commit Bot]

Comment on attachment 223559 [details]
Patch

Rejecting attachment 223559 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 223559, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit2/ChangeLog is not at the top of the file.

Full output: http://webkit-queues.appspot.com/results/6059916125011968

[Carlos Garcia Campos]

Comment on attachment 223559 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223559&action=review

> Source/WebKit2/ChangeLog:3
>  2014-02-07  Piotr Grad  <[e-mail]>
>  
> [phone]  Piotr Grad  <[e-mail]>

Right, this is wrong

> Source/WebKit2/ChangeLog:15
> +
>          [GTK] Build break in WebKitSettings

The date and author should be here. Please fix the changelog :-)

[Piotr Grad]

Created attachment 223561 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 223561 [details]
Patch

Clearing flags on attachment: 223561

Committed r163708: <http://trac.webkit.org/changeset/163708>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.