Bug 128449 - [GTK] Build break in WebKitWebViewBase.cpp::webkitWebViewBaseCreateWebPage
Summary: [GTK] Build break in WebKitWebViewBase.cpp::webkitWebViewBaseCreateWebPage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-07 23:50 PST by Piotr Grad
Modified: 2014-02-08 01:21 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2014-02-07 23:52 PST, Piotr Grad 		no flags Details | Formatted Diff | Diff
Patch (1.56 KB, patch)
2014-02-07 23:54 PST, Piotr Grad 		cgarcia: review-
Details | Formatted Diff | Diff
Patch (1.48 KB, patch)
2014-02-08 00:25 PST, Piotr Grad 		cgarcia: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch (1.48 KB, patch)
2014-02-08 00:44 PST, Piotr Grad 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Grad 2014-02-07 23:50:25 PST 
context->createWebPage is called with inproper parameter
Comment 1 Piotr Grad 2014-02-07 23:52:31 PST 
Created attachment 223556 [details]
Patch
Comment 2 WebKit Commit Bot 2014-02-07 23:54:18 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Piotr Grad 2014-02-07 23:54:52 PST 
Created attachment 223557 [details]
Patch
Comment 4 Carlos Garcia Campos 2014-02-07 23:58:50 PST 
Comment on attachment 223557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223557&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:957
> +    webPageConfiguration.relatedPage = webkitWebViewBaseGetPage(webkitWebViewBase);

This is not correct, you are using the page you are creating as the related page. You should not initialize the related page (it's already null at this point), is currently unimplemented in gtk+ port.
Comment 5 Piotr Grad 2014-02-08 00:25:57 PST 
Created attachment 223559 [details]
Patch
Comment 6 Carlos Garcia Campos 2014-02-08 00:28:27 PST 
Comment on attachment 223559 [details]
Patch

Thank you!
Comment 7 WebKit Commit Bot 2014-02-08 00:31:11 PST 
Comment on attachment 223559 [details]
Patch

Rejecting attachment 223559 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 223559, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit2/ChangeLog is not at the top of the file.

Full output: http://webkit-queues.appspot.com/results/6059916125011968
Comment 8 Carlos Garcia Campos 2014-02-08 00:34:23 PST 
Comment on attachment 223559 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223559&action=review

> Source/WebKit2/ChangeLog:3
>  2014-02-07  Piotr Grad  <p.grad@samsung.com>
>  
> +2014-02-07  Piotr Grad  <p.grad@samsung.com>

Right, this is wrong

> Source/WebKit2/ChangeLog:15
> +
>          [GTK] Build break in WebKitSettings

The date and author should be here. Please fix the changelog :-)
Comment 9 Piotr Grad 2014-02-08 00:44:51 PST 
Created attachment 223561 [details]
Patch
Comment 10 WebKit Commit Bot 2014-02-08 01:21:49 PST 
Comment on attachment 223561 [details]
Patch

Clearing flags on attachment: 223561

Committed r163708: <http://trac.webkit.org/changeset/163708>
Comment 11 WebKit Commit Bot 2014-02-08 01:21:51 PST 
All reviewed patches have been landed.  Closing bug.