Bug 128442 - IDB: storage/indexeddb/mozilla/versionchange-abort.html fails
Summary: IDB: storage/indexeddb/mozilla/versionchange-abort.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks: 128480
  Show dependency tree / graph
 
Reported: 2014-02-07 22:15 PST by Brady Eidson
Modified: 2014-02-09 00:11 PST (History)
2 users (show)

See Also:

Attachments
Patch v1 (5.22 KB, patch)
2014-02-07 22:19 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v2 - Decided against adding all the other tests at once as I believe there's some strange interactions. (3.16 KB, patch)
2014-02-08 15:35 PST, Brady Eidson 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-02-07 22:15:16 PST 
IDB: storage/indexeddb/mozilla/versionchange-abort.html fails

When the database metadata has the special "no version set yet" version of INT64_MAX, we need to return 0 to the bindings.  Not INT64_MAX.
Comment 1 Radar WebKit Bug Importer 2014-02-07 22:15:47 PST 
<rdar://problem/16018887>
Comment 2 Brady Eidson 2014-02-07 22:19:24 PST 
Created attachment 223549 [details]
Patch v1
Comment 3 Brady Eidson 2014-02-08 15:35:58 PST 
Created attachment 223590 [details]
Patch v2 - Decided against adding all the other tests at once as I believe there's some strange interactions.
Comment 4 Brady Eidson 2014-02-08 15:57:42 PST 
http://trac.webkit.org/changeset/163729
Comment 5 Ryosuke Niwa 2014-02-08 19:33:14 PST 
Landed a EFL build fix in http://trac.webkit.org/changeset/16373.
Comment 6 Brady Eidson 2014-02-08 21:48:25 PST 
Sorry for the breakage, that's what losing EWS does...

(In reply to comment #5)
> Landed a EFL build fix in http://trac.webkit.org/changeset/16373.

I think you meant http://trac.webkit.org/changeset/163736

I'm shocked that fix is necessary...  anybody have a link to the build failure?

On the surface that fix suggests to me the EFL compiler is inadequate.
Comment 7 Ryosuke Niwa 2014-02-09 00:11:55 PST 
http://build.webkit.org/builders/EFL%20Linux%2032-bit%20Release%20%28Build%29/builds/26631/steps/compile-webkit/logs/stdio

/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp: In member function 'uint64_t WebCore::IDBDatabase::version() const':
/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:140:112: error: enumeral and non-enumeral type in conditional expression [-Werror]