Bug 128441 - Split UserTriggered into FireSelectEvent and RevealSelection for selection options
Summary: Split UserTriggered into FireSelectEvent and RevealSelection for selection op...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 127832
  Show dependency tree / graph
 
Reported: 2014-02-07 22:13 PST by Ryosuke Niwa
Modified: 2014-02-08 13:35 PST (History)
7 users (show)

See Also:

Attachments
Cleanup (18.11 KB, patch)
2014-02-07 22:20 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-02-07 22:13:13 PST 
Right now a lot of functions call setSelection with UserTriggered and DoNotRevealSelection
in order to let select event fire without revealing selection.

We should split UserTriggered into FireSelectEvent and RevealSelection instead.
Comment 1 Ryosuke Niwa 2014-02-07 22:20:56 PST 
Created attachment 223550 [details]
Cleanup
Comment 2 WebKit Commit Bot 2014-02-08 13:35:35 PST 
Comment on attachment 223550 [details]
Cleanup

Clearing flags on attachment: 223550

Committed r163721: <http://trac.webkit.org/changeset/163721>
Comment 3 WebKit Commit Bot 2014-02-08 13:35:37 PST 
All reviewed patches have been landed.  Closing bug.