Bug 128440 - Clean up MarkupAccumulator::appendCharactersReplacingEntities
Summary: Clean up MarkupAccumulator::appendCharactersReplacingEntities
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-07 21:18 PST by Benjamin Poulain
Modified: 2014-02-10 18:42 PST (History)
0 users

See Also:

Attachments
Patch (7.35 KB, patch)
2014-02-07 21:23 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (7.27 KB, patch)
2014-02-09 19:30 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (7.27 KB, patch)
2014-02-09 20:37 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-02-07 21:18:51 PST 
Clean up MarkupAccumulator::appendCharactersReplacingEntities
Comment 1 Benjamin Poulain 2014-02-07 21:23:23 PST 
Created attachment 223546 [details]
Patch
Comment 2 Benjamin Poulain 2014-02-09 19:30:46 PST 
Created attachment 223665 [details]
Patch
Comment 3 Benjamin Poulain 2014-02-09 20:37:27 PST 
Created attachment 223669 [details]
Patch
Comment 4 Darin Adler 2014-02-09 23:51:03 PST 
Comment on attachment 223669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223669&action=review

> Source/WebCore/editing/MarkupAccumulator.cpp:55
> +static EntityDescription entitySubstitutionList[] = {

const

> Source/WebCore/editing/MarkupAccumulator.cpp:74
> +static uint8_t entityMap[maximumEscapedentityCharacter + 1] = {

const
Comment 5 Benjamin Poulain 2014-02-10 18:42:53 PST 
Committed r163854: <http://trac.webkit.org/changeset/163854>