Bug 128439 - Merge updateSelectionCachesIfSelectionIsInsideTextFormControl into setSelectionWithoutUpdatingAppearance
Summary: Merge updateSelectionCachesIfSelectionIsInsideTextFormControl into setSelecti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 127832
  Show dependency tree / graph
 
Reported: 2014-02-07 20:53 PST by Ryosuke Niwa
Modified: 2014-02-07 21:22 PST (History)
5 users (show)

See Also:

Attachments
Cleanup (7.37 KB, patch)
2014-02-07 20:59 PST, Ryosuke Niwa 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-02-07 20:53:02 PST 
FrameSelection::selectAll() has superfluous call to updateSelectionCachesIfSelectionIsInsideTextFormControl and selectFrameElementInParentIfFullySelected
because it doesn't call setSelection with UserTriggered set.

Do that and merge updateSelectionCachesIfSelectionIsInsideTextFormControl into setSelectionWithoutUpdatingAppearance
Comment 1 Ryosuke Niwa 2014-02-07 20:59:52 PST 
Created attachment 223544 [details]
Cleanup
Comment 2 Ryosuke Niwa 2014-02-07 21:22:18 PST 
Committed r163692: <http://trac.webkit.org/changeset/163692>