Bug 128435 - CTTE: ApplicationCacheHost always has a DocumentLoader.
Summary: CTTE: ApplicationCacheHost always has a DocumentLoader.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-07 19:09 PST by Andreas Kling
Modified: 2014-07-04 17:17 PDT (History)
5 users (show)

See Also:

Attachments
Patch (14.14 KB, patch)
2014-02-07 19:09 PST, Andreas Kling 		sam: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-02-07 19:09:14 PST 
CTTE: ApplicationCacheHost always has a DocumentLoader.
Comment 1 Andreas Kling 2014-02-07 19:09:41 PST 
Created attachment 223540 [details]
Patch
Comment 2 WebKit Commit Bot 2014-07-04 10:30:17 PDT 
Comment on attachment 223540 [details]
Patch

Rejecting attachment 223540 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 223540, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
of 17 hunks FAILED -- saving rejects to file Source/WebCore/loader/appcache/ApplicationCacheHost.cpp.rej
patching file Source/WebCore/loader/appcache/ApplicationCacheHost.h
Hunk #2 FAILED at 155.
Hunk #3 succeeded at 165 (offset 1 line).
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/loader/appcache/ApplicationCacheHost.h.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/4862202292994048
Comment 3 Andreas Kling 2014-07-04 17:17:42 PDT 
Landed in http://trac.webkit.org/changeset/170807