RESOLVED FIXED 128428
Remove isInitialState flag from Page::setViewState 
https://bugs.webkit.org/show_bug.cgi?id=128428
Summary Remove isInitialState flag from Page::setViewState
Gavin Barraclough
Reported 2014-02-07 17:57:09 PST
This is used for two purposes; one is unnecessary, the other is a bug.
Attachments
Fix (17.60 KB, patch)
2014-02-07 18:02 PST, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2014-02-07 18:02:37 PST
Created attachment 223532 [details] Fix
WebKit Commit Bot
Comment 2 2014-02-07 18:04:57 PST
Attachment 223532 [details] did not pass style-queue: ERROR: Source/WebCore/page/Page.h:294: The parameter name "isVisible" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/page/Page.h:422: The parameter name "isVisible" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 4 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 3 2014-02-07 18:20:22 PST
Transmitting file data ................ Committed revision 163679.
Note You need to log in before you can comment on or make changes to this bug.