IDB: storage/indexeddb/mozilla/cursors.html fails -For object store cursors, we forgot to set the primary key. -For openCursor() with no results, we incorrectly return a cursor with undefined values when we're supposed to return a null cursor.
<rdar://problem/16017998>
(In reply to comment #0) > -For object store cursors, we forgot to set the primary key. > -For openCursor() with no results, we incorrectly return a cursor with undefined values when we're supposed to return a null cursor. Also, for iterating to a targetKey, we only tested for exact matches to the target key, instead of the "next key passed the target"
Created attachment 223547 [details] Patch v1
Attachment 223547 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:154: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 223547 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=223547&action=review > Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:159 > m_callbacks->onSuccess(static_cast<SharedBuffer*>(0)); Why do we need this cast? Can’t we just say nullptr? Is there some weird overloading issue?
(In reply to comment #5) > (From update of attachment 223547 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223547&action=review > > > Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:159 > > m_callbacks->onSuccess(static_cast<SharedBuffer*>(0)); > > Why do we need this cast? Can’t we just say nullptr? Is there some weird overloading issue? Sadly, yes - A massive overloading issue, in fact. If you want to cringe, take a look at IDBCallbacks.h Thanks for the review!
http://trac.webkit.org/changeset/163728