Bug 128418 – [GTK] generate-gtkdoc should use argparse

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

It's 2014.

[Martin Robinson]

Created attachment 224457 [details]
Patch

[Martin Robinson]

This patch also disposes of the common options method. The option methods will disappear completely in 128417.

[Carlos Garcia Campos]

Comment on attachment 224457 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224457&action=review

> Tools/gtk/generate-gtkdoc:170
> -    options = get_common_options().copy()
> -    options.update({
> +    options = {
> +        'decorator': 'WEBKIT_API|WEBKIT_DEPRECATED|WEBKIT_DEPRECATED_FOR\(.+\)',
> +        'deprecation_guard': 'WEBKIT_DISABLE_DEPRECATED',
> +        'library_path' : common.library_build_path(),
> +        'virtual_root' : virtual_root,

Why are we now duplicating this code in every get_*_options method?

[Martin Robinson]

(In reply to comment #3)
> (From update of attachment 224457 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=224457&action=review
> 
> > Tools/gtk/generate-gtkdoc:170
> > -    options = get_common_options().copy()
> > -    options.update({
> > +    options = {
> > +        'decorator': 'WEBKIT_API|WEBKIT_DEPRECATED|WEBKIT_DEPRECATED_FOR\(.+\)',
> > +        'deprecation_guard': 'WEBKIT_DISABLE_DEPRECATED',
> > +        'library_path' : common.library_build_path(),
> > +        'virtual_root' : virtual_root,
> 
> Why are we now duplicating this code in every get_*_options method?

It's a bit awkward like this, but it makes sense because in the next patch in the series these are no longer duplicated.

[Martin Robinson]

Committed r164560: <http://trac.webkit.org/changeset/164560>