WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
128409
Unify JSLock implementation for iOS and non-iOS ports.
https://bugs.webkit.org/show_bug.cgi?id=128409
Summary
Unify JSLock implementation for iOS and non-iOS ports.
Mark Lam
Reported
2014-02-07 15:54:34 PST
Patch coming. Details will in the ChangeLog in the patch.
Attachments
the patch.
(4.75 KB, patch)
2014-02-07 17:12 PST
,
Mark Lam
ggaren
: review-
Details
Formatted Diff
Diff
patch 2: just there part that makes everyone do drop/grab locks the iOS way.
(4.37 KB, patch)
2014-02-07 18:20 PST
,
Mark Lam
msaboff
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2014-02-07 17:12:28 PST
Created
attachment 223522
[details]
the patch.
Mark Hahnenberg
Comment 2
2014-02-07 17:13:47 PST
Comment on
attachment 223522
[details]
the patch. We don't need a special case for dropAllLocks() now that we're on the C stack. You might be able to just make dropAllLocksUnconditionally be the only dropAllLocks.
Mark Lam
Comment 3
2014-02-07 17:14:38 PST
Comment on
attachment 223522
[details]
the patch. View in context:
https://bugs.webkit.org/attachment.cgi?id=223522&action=review
> Source/JavaScriptCore/ChangeLog:12 > + In the process of switching to iOS implementation, I compared the
typo: to "the" iOS implementation. Will fix.
> Source/JavaScriptCore/ChangeLog:14 > + implementation has a bug in dropAllLocks() and dropAllLocksUnconditionally().().
Redundant "().". Will fix.
Mark Lam
Comment 4
2014-02-07 17:15:59 PST
Comment on
attachment 223522
[details]
the patch. View in context:
https://bugs.webkit.org/attachment.cgi?id=223522&action=review
> Source/JavaScriptCore/ChangeLog:16 > + The bug is that they do not clear our m_vm->stackPointerAtVMEntry and
typo: our ==> out.
> Source/JavaScriptCore/ChangeLog:18 > + JSLock::unlock() to dropAllLocks() and dropAllLocksUnconditionally().
Missing ")" after "JSLock::unlock()". Will fix.
Geoffrey Garen
Comment 5
2014-02-07 17:25:35 PST
Comment on
attachment 223522
[details]
the patch. Split out the bug fix, please.
Mark Lam
Comment 6
2014-02-07 18:20:06 PST
Created
attachment 223534
[details]
patch 2: just there part that makes everyone do drop/grab locks the iOS way.
Michael Saboff
Comment 7
2014-02-07 18:38:08 PST
Comment on
attachment 223534
[details]
patch 2: just there part that makes everyone do drop/grab locks the iOS way. r=me
Mark Lam
Comment 8
2014-02-07 18:47:46 PST
Thanks. Landed in
r163685
: <
http://trac.webkit.org/r163685
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug