Bug 128409 - Unify JSLock implementation for iOS and non-iOS ports.
Summary: Unify JSLock implementation for iOS and non-iOS ports.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-07 15:54 PST by Mark Lam
Modified: 2014-02-07 18:47 PST (History)
6 users (show)

See Also:


Attachments
the patch. (4.75 KB, patch)
2014-02-07 17:12 PST, Mark Lam
ggaren: review-
Details | Formatted Diff | Diff
patch 2: just there part that makes everyone do drop/grab locks the iOS way. (4.37 KB, patch)
2014-02-07 18:20 PST, Mark Lam
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-02-07 15:54:34 PST
Patch coming.  Details will in the ChangeLog in the patch.
Comment 1 Mark Lam 2014-02-07 17:12:28 PST
Created attachment 223522 [details]
the patch.
Comment 2 Mark Hahnenberg 2014-02-07 17:13:47 PST
Comment on attachment 223522 [details]
the patch.

We don't need a special case for dropAllLocks() now that we're on the C stack. You might be able to just make dropAllLocksUnconditionally be the only dropAllLocks.
Comment 3 Mark Lam 2014-02-07 17:14:38 PST
Comment on attachment 223522 [details]
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=223522&action=review

> Source/JavaScriptCore/ChangeLog:12
> +        In the process of switching to iOS implementation, I compared the

typo: to "the" iOS implementation.  Will fix.

> Source/JavaScriptCore/ChangeLog:14
> +        implementation has a bug in dropAllLocks() and dropAllLocksUnconditionally().().

Redundant "().".  Will fix.
Comment 4 Mark Lam 2014-02-07 17:15:59 PST
Comment on attachment 223522 [details]
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=223522&action=review

> Source/JavaScriptCore/ChangeLog:16
> +        The bug is that they do not clear our m_vm->stackPointerAtVMEntry and

typo: our ==> out.

> Source/JavaScriptCore/ChangeLog:18
> +        JSLock::unlock() to dropAllLocks() and dropAllLocksUnconditionally().

Missing ")" after "JSLock::unlock()".  Will fix.
Comment 5 Geoffrey Garen 2014-02-07 17:25:35 PST
Comment on attachment 223522 [details]
the patch.

Split out the bug fix, please.
Comment 6 Mark Lam 2014-02-07 18:20:06 PST
Created attachment 223534 [details]
patch 2: just there part that makes everyone do drop/grab locks the iOS way.
Comment 7 Michael Saboff 2014-02-07 18:38:08 PST
Comment on attachment 223534 [details]
patch 2: just there part that makes everyone do drop/grab locks the iOS way.

r=me
Comment 8 Mark Lam 2014-02-07 18:47:46 PST
Thanks.  Landed in r163685: <http://trac.webkit.org/r163685>.