RESOLVED FIXED 128407
Remove some unused functions from SerializedScriptValue 
https://bugs.webkit.org/show_bug.cgi?id=128407
Summary Remove some unused functions from SerializedScriptValue
Alexey Proskuryakov
Reported 2014-02-07 15:28:55 PST
SerializedScriptValue has accumulated a lot of cruft. I'll remove it in small steps, as maybe some ports still use some of that.
Attachments
proposed patch (5.00 KB, patch)
2014-02-07 15:30 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
part 2 (8.48 KB, patch)
2014-02-08 15:29 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
part 3 (7.55 KB, patch)
2014-02-10 13:18 PST, Alexey Proskuryakov 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-02-07 15:30:07 PST
Created attachment 223504 [details] proposed patch
WebKit Commit Bot
Comment 2 2014-02-07 17:05:04 PST
Comment on attachment 223504 [details] proposed patch Clearing flags on attachment: 223504 Committed r163667: <http://trac.webkit.org/changeset/163667>
WebKit Commit Bot
Comment 3 2014-02-07 17:05:07 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 4 2014-02-08 15:23:28 PST
Re-opening for more.
Alexey Proskuryakov
Comment 5 2014-02-08 15:29:32 PST
Created attachment 223589 [details] part 2
WebKit Commit Bot
Comment 6 2014-02-08 17:16:36 PST
Comment on attachment 223589 [details] part 2 Clearing flags on attachment: 223589 Committed r163732: <http://trac.webkit.org/changeset/163732>
WebKit Commit Bot
Comment 7 2014-02-08 17:16:38 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 8 2014-02-10 13:16:21 PST
And yet more.
Alexey Proskuryakov
Comment 9 2014-02-10 13:18:31 PST
Created attachment 223737 [details] part 3
WebKit Commit Bot
Comment 10 2014-02-10 13:21:33 PST
Attachment 223737 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/IDBBindingUtilities.cpp:335: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:146: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 11 2014-02-10 13:32:10 PST
Committed <http://trac.webkit.org/r163810>.
Note You need to log in before you can comment on or make changes to this bug.