Bug 128402 – Implement DataCue for metadata cues

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Brendan Long]

See:

http://www.w3.org/html/wg/drafts/html/CR/embedded-content-0.html#datacue

This allows us to add binary metadata cues.

[Brendan Long]

Created attachment 223778 [details]
Patch

[Brendan Long]

The implementation of .text leaves something to be desired, but I have no idea how to do content sniffing. For in-band DataCues, we could use a constructor that takes a String instead of an ArrayBuffer, but I wasn't sure if that should be added now.

[Brendan Long]

Created attachment 223798 [details]
Patch

This one should make JSDataCue build correctly for Mac WebKit.

[Build Bot]

Comment on attachment 223798 [details]
Patch

Attachment 223798 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4829588383334400

New failing tests:
media/track/track-datacue.html
js/dom/global-constructors-attributes.html

[Build Bot]

Created attachment 223810 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 223798 [details]
Patch

Attachment 223798 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5609549880885248

New failing tests:
media/track/track-datacue.html
js/dom/global-constructors-attributes.html

[Build Bot]

Created attachment 223814 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 223798 [details]
Patch

Attachment 223798 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5744471312433152

New failing tests:
media/track/track-datacue.html
js/dom/global-constructors-attributes.html

[Build Bot]

Created attachment 223824 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 223798 [details]
Patch

Attachment 223798 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6546895086288896

New failing tests:
media/track/track-datacue.html
js/dom/global-constructors-attributes.html

[Build Bot]

Created attachment 223832 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Brendan Long]

Created attachment 223870 [details]
Patch

This should fix the test failures.

[Eric Carlson]

Comment on attachment 223870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223870&action=review

> Source/WebCore/html/track/DataCue.cpp:55
> +    return const_cast<DataCue*>(toDataCue(const_cast<const TextTrackCue*>(cue)));

Ick, that is a mouthful. Is it really worth the double cast so you can call the other form of toDataCue and not duplicate the ASSERT here?

> Source/WebCore/html/track/TextTrack.cpp:283
>  
> +    if (cue->cueType() == TextTrackCue::Data && kind() != metadataKeyword()) {

Nit: I think it would be helpful to include the spec text here as a comment.

[Build Bot]

Comment on attachment 223870 [details]
Patch

Attachment 223870 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5286323795525632

New failing tests:
js/dom/global-constructors-attributes.html

[Build Bot]

Created attachment 223878 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Brendan Long]

Created attachment 223881 [details]
Patch

Added spec text to addCue(), duplicated the ASSERT in toDataCue() instead of doing two const_casts, and added DataCue to one more test -expected.txt file.

[Brendan Long]

Here's the windows build failure:

     1>WebCore.lib(JSBindingsAllInOne.obj) : error LNK2019: unresolved external symbol "public: static class JSC::JSObject * __cdecl WebCore::JSDataCue::createPrototype(class JSC::VM &,class JSC::JSGlobalObject *)" (?createPrototype@JSDataCue@WebCore@@SAPAVJSObject@JSC@@AAVVM@4@PAVJSGlobalObject@4@@Z) referenced in function "class JSC::Structure * __cdecl WebCore::getDOMStructure<class WebCore::JSDataCue>(class JSC::VM &,class WebCore::JSDOMGlobalObject *)" (??$getDOMStructure@VJSDataCue@WebCore@@@WebCore@@YAPAVStructure@JSC@@AAVVM@2@PAVJSDOMGlobalObject@0@@Z)
     1>WebCore.lib(JSBindingsAllInOne.obj) : error LNK2019: unresolved external symbol "protected: __thiscall WebCore::JSDataCue::JSDataCue(class JSC::Structure *,class WebCore::JSDOMGlobalObject *,class WTF::PassRefPtr<class WebCore::DataCue>)" (??0JSDataCue@WebCore@@IAE@PAVStructure@JSC@@PAVJSDOMGlobalObject@1@V?$PassRefPtr@VDataCue@WebCore@@@WTF@@@Z) referenced in function "public: static class WebCore::JSDataCue * __cdecl WebCore::JSDataCue::create(class JSC::Structure *,class WebCore::JSDOMGlobalObject *,class WTF::PassRefPtr<class WebCore::DataCue>)" (?create@JSDataCue@WebCore@@SAPAV12@PAVStructure@JSC@@PAVJSDOMGlobalObject@2@V?$PassRefPtr@VDataCue@WebCore@@@WTF@@@Z)
     1>WebCore.lib(JSBindingsAllInOne.obj) : error LNK2019: unresolved external symbol "protected: void __thiscall WebCore::JSDataCue::finishCreation(class JSC::VM &)" (?finishCreation@JSDataCue@WebCore@@IAEXAAVVM@JSC@@@Z) referenced in function "public: static class WebCore::JSDataCue * __cdecl WebCore::JSDataCue::create(class JSC::Structure *,class WebCore::JSDOMGlobalObject *,class WTF::PassRefPtr<class WebCore::DataCue>)" (?create@JSDataCue@WebCore@@SAPAV12@PAVStructure@JSC@@PAVJSDOMGlobalObject@2@V?$PassRefPtr@VDataCue@WebCore@@@WTF@@@Z)
     1>WebCore.lib(JSBindingsAllInOne.obj) : error LNK2001: unresolved external symbol "protected: static struct JSC::ClassInfo const WebCore::JSDataCue::s_info" (?s_info@JSDataCue@WebCore@@1UClassInfo@JSC@@B)
     1>WebCore.lib(DerivedSources.obj) : error LNK2019: unresolved external symbol "public: static class JSC::JSValue __cdecl WebCore::JSDataCue::getConstructor(class JSC::VM &,class JSC::JSGlobalObject *)" (?getConstructor@JSDataCue@WebCore@@SA?AVJSValue@JSC@@AAVVM@4@PAVJSGlobalObject@4@@Z) referenced in function "public: static bool __cdecl WebCore::JSDOMWindowConstructor::getOwnPropertySlot(class JSC::JSObject *,class JSC::ExecState *,class JSC::PropertyName,class JSC::PropertySlot &)" (?getOwnPropertySlot@JSDOMWindowConstructor@WebCore@@SA_NPAVJSObject@JSC@@PAVExecState@4@VPropertyName@4@AAVPropertySlot@4@@Z)
     1>C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\bin32\WebKit.dll : fatal error LNK1120: 5 unresolved externals
     1>Done Building Project "C:\cygwin\home\buildbot\WebKit\Source\WebKit\WebKit.vcxproj\WebKit\WebKit.vcxproj" (Build target(s)) -- FAILED.

I'm not sure where to add JSDataCue or DataCue.idl. "git grep git grep TextTrackCue Source/WebCore/WebCore.vcxproj/" didn't show any JS* or *.idl files.

[Brendan Long]

Created attachment 223890 [details]
Patch

This might fix the Windows build? I added DataCue.h to another part of the project file.

[Brendan Long]

Created attachment 223988 [details]
Patch

Added JSDataCue.cpp to DerivedSources.cpp

[WebKit Commit Bot]

Comment on attachment 223988 [details]
Patch

Rejecting attachment 223988 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 223988, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6610797220331520

[WebKit Commit Bot]

Comment on attachment 223988 [details]
Patch

Clearing flags on attachment: 223988

Committed r163974: <http://trac.webkit.org/changeset/163974>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.