Bug 12840 – REGRESSION(r16987-r16994): MSN Soapbox content not erased properly

• Status: RESOLVED
• Resolution: FIXED
• Component: Evangelism

[Velimir Ljubic]

Hello,

many problems in viewing site with latest WebKit as of 21/02/2007. Text is going all over another text and so on...

Hope this helps,

Velimir

[David Kilzer (:ddkilzer)]

Could you post a screen shot of what the page looks like?  It doesn't look very bad to me, but I'm using a local debug build of WebKit r19729 with Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8L127).

[Velimir Ljubic]

I am sorry I was not specific enough. It looks OK at first site, but once you try to navigate through videos or comments or other it just overlaps text etc. I will try to upload screenshot. Thanks!

[Velimir Ljubic]

Created attachment 13293 [details]
A screenshot of mess

[Velimir Ljubic]

Created attachment 13295 [details]
Another screenshot of mess

[Matt Lilek]

Confirmed with r19579, this is also a regression from Safari 2.0.4

The easiest way to see the bug is to view a video then click around the tabs below the video.

I'm sure there's a better way to describe this than "erased" but I'm not sure exactly what that is right now...

CC:ing Antti since things that don't go away might be visible objects with invisible parents :-)
Would be nice to know when the regression happened.

[Matt Lilek]

Regressed between r16987 and r16994 with http://trac.webkit.org/projects/webkit/changeset/16988 looking like the culprit.

[Antti Koivisto]

Yeah, almost certainly another bug 12368. The site is very ajaxy and bit hard to turn into a local test case but a quick look reveals a Safari test and Safari specific stylesheets setting visibility:visible on some elements, a usual sign of site relying on old buggy Webkit behavior.

[David Kilzer (:ddkilzer)]

Per Comment #8, this will most likely be an evangelism issue for soapbox.msn.com.

[Antti Koivisto]

Yes, looks like evangelism issue. The script has code like this for hiding the elements on the right:

            if (window.console)
              b[c].divElt.style.visibility = "hidden";
            else
              b[c].divElt.style.display = "none";

window.console is a Safari test so e.style.display = "none" gets applied on all non-Safari browsers. Before fix of bug 4377 visibility = "hidden" was enough to hide even visible children, now it is not.

The problem in the second screenshot is not a regression, it also happens with shipping Safari. It seems also be related to buggy Safari specific codepaths that do window.console test.

[Mark Rowe (bdash)]

<rdar://problem/5045727>

[Robert Blaut]

http://soapbox.msn.com redirects now to http://video.msn.com/video.aspx?mkt=en-us&tab=soapbox

On this page the is no described issue.  Entire page works correctly now. So the bug is fixed.