Bug 128393 – -webkit-clip-path should support fill, stroke, view-box keywords

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Dirk Schulze]

The CSS Masking specification demands the support of the keywords fill, stroke and view-box. The keyword bounding-box should be removed instead (never shipped in a browser).

[Dirk Schulze]

Created attachment 223628 [details]
Patch

[Dirk Schulze]

Created attachment 223629 [details]
Patch

[Dirk Schulze]

Created attachment 223630 [details]
Patch

[Build Bot]

Comment on attachment 223630 [details]
Patch

Attachment 223630 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6373636105568256

New failing tests:
fast/masking/parsing-clip-path-shape.html

[Build Bot]

Created attachment 223631 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 223630 [details]
Patch

Attachment 223630 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5582130138578944

New failing tests:
fast/masking/parsing-clip-path-shape.html

[Build Bot]

Created attachment 223633 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 223630 [details]
Patch

Attachment 223630 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5388951099539456

New failing tests:
fast/masking/parsing-clip-path-shape.html

[Build Bot]

Created attachment 223634 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 223630 [details]
Patch

Attachment 223630 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5480236200230912

New failing tests:
fast/masking/parsing-clip-path-shape.html

[Build Bot]

Created attachment 223636 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Dirk Schulze]

Created attachment 223657 [details]
Patch

Forgot to update test expectation.

[Dean Jackson]

Comment on attachment 223657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223657&action=review

> Source/WebCore/rendering/svg/SVGRenderingContext.cpp:128
> +            // FIXME: strokeBoundingBox() takes dasharray into account but shouldn't.

Where is the bug? :)

[Dirk Schulze]

(In reply to comment #13)
> (From update of attachment 223657 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223657&action=review
> 
> > Source/WebCore/rendering/svg/SVGRenderingContext.cpp:128
> > +            // FIXME: strokeBoundingBox() takes dasharray into account but shouldn't.
> 
> Where is the bug? :)

I hoped to find a reviewer not noticing the missing link. Will open the bug now :D

[WebKit Commit Bot]

Comment on attachment 223657 [details]
Patch

Clearing flags on attachment: 223657

Committed r163764: <http://trac.webkit.org/changeset/163764>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.