Bug 128393 - -webkit-clip-path should support fill, stroke, view-box keywords
Summary: -webkit-clip-path should support fill, stroke, view-box keywords
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: http://dev.w3.org/fxtf/masking/#typed...
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-07 13:25 PST by Dirk Schulze
Modified: 2014-02-09 21:57 PST (History)
18 users (show)

See Also:

Attachments
Patch (20.11 KB, patch)
2014-02-09 05:35 PST, Dirk Schulze 		no flags Details | Formatted Diff | Diff
Patch (20.01 KB, patch)
2014-02-09 08:49 PST, Dirk Schulze 		no flags Details | Formatted Diff | Diff
Patch (31.04 KB, patch)
2014-02-09 08:53 PST, Dirk Schulze 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (456.05 KB, application/zip)
2014-02-09 10:03 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (488.91 KB, application/zip)
2014-02-09 10:35 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (453.79 KB, application/zip)
2014-02-09 10:56 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (491.61 KB, application/zip)
2014-02-09 11:40 PST, Build Bot 		no flags Details
Patch (35.67 KB, patch)
2014-02-09 16:42 PST, Dirk Schulze 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2014-02-07 13:25:23 PST 
The CSS Masking specification demands the support of the keywords fill, stroke and view-box. The keyword bounding-box should be removed instead (never shipped in a browser).
Comment 1 Dirk Schulze 2014-02-09 05:35:24 PST 
Created attachment 223628 [details]
Patch
Comment 2 Dirk Schulze 2014-02-09 08:49:47 PST 
Created attachment 223629 [details]
Patch
Comment 3 Dirk Schulze 2014-02-09 08:53:09 PST 
Created attachment 223630 [details]
Patch
Comment 4 Build Bot 2014-02-09 10:03:48 PST 
Comment on attachment 223630 [details]
Patch

Attachment 223630 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6373636105568256

New failing tests:
fast/masking/parsing-clip-path-shape.html
Comment 5 Build Bot 2014-02-09 10:03:56 PST 
Created attachment 223631 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Build Bot 2014-02-09 10:35:54 PST 
Comment on attachment 223630 [details]
Patch

Attachment 223630 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5582130138578944

New failing tests:
fast/masking/parsing-clip-path-shape.html
Comment 7 Build Bot 2014-02-09 10:35:59 PST 
Created attachment 223633 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 8 Build Bot 2014-02-09 10:56:31 PST 
Comment on attachment 223630 [details]
Patch

Attachment 223630 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5388951099539456

New failing tests:
fast/masking/parsing-clip-path-shape.html
Comment 9 Build Bot 2014-02-09 10:56:36 PST 
Created attachment 223634 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 10 Build Bot 2014-02-09 11:39:57 PST 
Comment on attachment 223630 [details]
Patch

Attachment 223630 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5480236200230912

New failing tests:
fast/masking/parsing-clip-path-shape.html
Comment 11 Build Bot 2014-02-09 11:40:03 PST 
Created attachment 223636 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 12 Dirk Schulze 2014-02-09 16:42:29 PST 
Created attachment 223657 [details]
Patch

Forgot to update test expectation.
Comment 13 Dean Jackson 2014-02-09 21:25:44 PST 
Comment on attachment 223657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223657&action=review

> Source/WebCore/rendering/svg/SVGRenderingContext.cpp:128
> +            // FIXME: strokeBoundingBox() takes dasharray into account but shouldn't.

Where is the bug? :)
Comment 14 Dirk Schulze 2014-02-09 21:27:29 PST 
(In reply to comment #13)
> (From update of attachment 223657 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223657&action=review
> 
> > Source/WebCore/rendering/svg/SVGRenderingContext.cpp:128
> > +            // FIXME: strokeBoundingBox() takes dasharray into account but shouldn't.
> 
> Where is the bug? :)

I hoped to find a reviewer not noticing the missing link. Will open the bug now :D
Comment 15 WebKit Commit Bot 2014-02-09 21:57:43 PST 
Comment on attachment 223657 [details]
Patch

Clearing flags on attachment: 223657

Committed r163764: <http://trac.webkit.org/changeset/163764>
Comment 16 WebKit Commit Bot 2014-02-09 21:57:48 PST 
All reviewed patches have been landed.  Closing bug.