Bug 128390 - WebGL doesn't update with remotely hosted layers
Summary: WebGL doesn't update with remotely hosted layers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-07 13:11 PST by Dean Jackson
Modified: 2014-02-07 14:07 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.00 KB, patch)
2014-02-07 13:19 PST, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-02-07 13:11:18 PST 
WebGL doesn't push frames when attached to a remote layer host.
Comment 1 Dean Jackson 2014-02-07 13:12:24 PST 
<rdar://problem/15260182>
Comment 2 Dean Jackson 2014-02-07 13:19:37 PST 
Created attachment 223489 [details]
Patch
Comment 3 Simon Fraser (smfr) 2014-02-07 13:33:28 PST 
Comment on attachment 223489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223489&action=review

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:51
> +    bool m_providesContents;

You forgot to initialize this in the ctor.

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:62
> +    m_providesContents = [customLayer isKindOfClass:[WebGLLayer class]];

I think you could do this with the classname without pulling in WebGLLayer.h
Comment 4 Dean Jackson 2014-02-07 13:37:20 PST 
Comment on attachment 223489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223489&action=review

>> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:51
>> +    bool m_providesContents;
> 
> You forgot to initialize this in the ctor.

It's initalised in the ctor body.

>> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:62
>> +    m_providesContents = [customLayer isKindOfClass:[WebGLLayer class]];
> 
> I think you could do this with the classname without pulling in WebGLLayer.h

Yeah, I'm now trying to get there via GraphicsLayer
Comment 5 Dean Jackson 2014-02-07 14:07:57 PST 
Committed r163646: <http://trac.webkit.org/changeset/163646>