Bug 128389 – [GTK] Make process model names properly meaningful

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adrian Perez]

[GTK] Make process model names properly meaningful

[Adrian Perez]

Created attachment 223492 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Martin Robinson]

Comment on attachment 223492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223492&action=review

Looks good to me. Needs one more GTK+ reviewer to be committed.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:935
> +    if (newProcessModel != context->priv->context->processModel()) {
> +        context->priv->context->setUsesNetworkProcess(newProcessModel == ProcessModelMultipleSecondaryProcesses);
> +        context->priv->context->setProcessModel(newProcessModel);

Nit: This should probably be an early return.

[Adrian Perez]

Created attachment 223496 [details]
Patch

[Adrian Perez]

(In reply to comment #3)
> (From update of attachment 223492 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223492&
>
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:935
> > +    if (newProcessModel != context->priv->context->processModel()) {
> > +        context->priv->context->setUsesNetworkProcess(newProcessModel == ProcessModelMultipleSecondaryProcesses);
> > +        context->priv->context->setProcessModel(newProcessModel);
> 
> Nit: This should probably be an early return.

Updated patch, now there is an early return there :-)

[WebKit Commit Bot]

Comment on attachment 223496 [details]
Patch

Clearing flags on attachment: 223496

Committed r163698: <http://trac.webkit.org/changeset/163698>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.