Bug 128367 - [CSS Regions] Fix layout of floated nested region
Summary: [CSS Regions] Fix layout of floated nested region
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Radu Stavila
URL:
Keywords: AdobeTracked
Depends on:
Blocks: 57312
  Show dependency tree / graph
 
Reported: 2014-02-07 02:29 PST by Mihai Maerean
Modified: 2014-02-12 14:11 PST (History)
3 users (show)

See Also:

Attachments
layout test that fails (2.00 KB, text/html)
2014-02-07 02:29 PST, Mihai Maerean 		no flags Details
layout test expected result (2.07 KB, text/html)
2014-02-07 02:30 PST, Mihai Maerean 		no flags Details
Test (4.97 KB, patch)
2014-02-12 09:03 PST, Radu Stavila 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Maerean 2014-02-07 02:29:24 PST 
Created attachment 223439 [details]
layout test that fails

The nested region with the float property is rendered as a block, not as a float.
Comment 1 Mihai Maerean 2014-02-07 02:30:09 PST 
Created attachment 223440 [details]
layout test expected result
Comment 2 Radu Stavila 2014-02-12 09:03:54 PST 
Created attachment 223973 [details]
Test

This bug is invalid. The problem in the attached test is that the nested region also has the outerContent class, which causes it to be directly flowed into the outer flow, making it a sibling of its parent. 
Simplified test and added it to the regions layout tests.
Comment 3 Mihnea Ovidenie 2014-02-12 09:08:39 PST 
Comment on attachment 223973 [details]
Test

r=me
Comment 4 WebKit Commit Bot 2014-02-12 14:11:54 PST 
Comment on attachment 223973 [details]
Test

Clearing flags on attachment: 223973

Committed r163985: <http://trac.webkit.org/changeset/163985>
Comment 5 WebKit Commit Bot 2014-02-12 14:11:56 PST 
All reviewed patches have been landed.  Closing bug.