Bug 128363 - WebKit2 View Gestures (Swipe): Support for iOS
Summary: WebKit2 View Gestures (Swipe): Support for iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-06 22:59 PST by Tim Horton
Modified: 2014-02-07 16:53 PST (History)
6 users (show)

See Also:


Attachments
very preliminary (96.78 KB, patch)
2014-02-07 01:36 PST, Tim Horton
no flags Details | Formatted Diff | Diff
patch (43.30 KB, patch)
2014-02-07 16:23 PST, Tim Horton
no flags Details | Formatted Diff | Diff
patch (43.72 KB, patch)
2014-02-07 16:42 PST, Tim Horton
no flags Details | Formatted Diff | Diff
patch (44.10 KB, patch)
2014-02-07 16:49 PST, Tim Horton
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-02-06 22:59:10 PST
<rdar://problem/15194194>
Comment 1 Tim Horton 2014-02-07 01:36:36 PST
Created attachment 223432 [details]
very preliminary

Caveats:

- will not build for the simulator
- forward swipe isn't working yet (no idea why)
- doesn't inform the app about the swipe state
- no changelog
- patch appears bigger than it actually is because of a rename (will split that out)
Comment 2 WebKit Commit Bot 2014-02-07 09:58:05 PST
Attachment 223432 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.h:37:  _UIViewControllerTransitionContext is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.h:38:  _UINavigationInteractiveTransitionBase is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.h:54:  The parameter name "transition" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-02-07 16:23:54 PST
Created attachment 223511 [details]
patch
Comment 4 WebKit Commit Bot 2014-02-07 16:26:31 PST
Attachment 223511 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:39:  _UIViewControllerTransitionContext is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:40:  _UINavigationInteractiveTransitionBase is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Anders Carlsson 2014-02-07 16:31:11 PST
Comment on attachment 223511 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223511&action=review

> Source/WebKit2/UIProcess/API/ios/WKContentView.h:52
> +- (CGImageRef)takeViewSnapshotForContentView:(WKContentView *)contentView;

I think this should return a RetainPtr as well.

> Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm:52
> +@interface WKSwipeInteractiveTransitionDelegate : NSObject <_UINavigationInteractiveTransitionBaseDelegate>

This is not a delegate. How about TransitionController?
Comment 6 Tim Horton 2014-02-07 16:42:19 PST
Created attachment 223516 [details]
patch
Comment 7 WebKit Commit Bot 2014-02-07 16:45:29 PST
Attachment 223516 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:39:  _UIViewControllerTransitionContext is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:40:  _UINavigationInteractiveTransitionBase is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Tim Horton 2014-02-07 16:49:48 PST
Created attachment 223518 [details]
patch
Comment 9 WebKit Commit Bot 2014-02-07 16:51:21 PST
Attachment 223518 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:39:  _UIViewControllerTransitionContext is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:40:  _UINavigationInteractiveTransitionBase is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Tim Horton 2014-02-07 16:53:38 PST
http://trac.webkit.org/changeset/163666