RESOLVED FIXED 128363
WebKit2 View Gestures (Swipe): Support for iOS
https://bugs.webkit.org/show_bug.cgi?id=128363
Summary WebKit2 View Gestures (Swipe): Support for iOS
Tim Horton
Reported 2014-02-06 22:59:10 PST
Attachments
very preliminary (96.78 KB, patch)
2014-02-07 01:36 PST, Tim Horton
no flags
patch (43.30 KB, patch)
2014-02-07 16:23 PST, Tim Horton
no flags
patch (43.72 KB, patch)
2014-02-07 16:42 PST, Tim Horton
no flags
patch (44.10 KB, patch)
2014-02-07 16:49 PST, Tim Horton
andersca: review+
Tim Horton
Comment 1 2014-02-07 01:36:36 PST
Created attachment 223432 [details] very preliminary Caveats: - will not build for the simulator - forward swipe isn't working yet (no idea why) - doesn't inform the app about the swipe state - no changelog - patch appears bigger than it actually is because of a rename (will split that out)
WebKit Commit Bot
Comment 2 2014-02-07 09:58:05 PST
Attachment 223432 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.h:37: _UIViewControllerTransitionContext is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.h:38: _UINavigationInteractiveTransitionBase is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.h:54: The parameter name "transition" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2014-02-07 16:23:54 PST
WebKit Commit Bot
Comment 4 2014-02-07 16:26:31 PST
Attachment 223511 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:39: _UIViewControllerTransitionContext is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:40: _UINavigationInteractiveTransitionBase is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 5 2014-02-07 16:31:11 PST
Comment on attachment 223511 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=223511&action=review > Source/WebKit2/UIProcess/API/ios/WKContentView.h:52 > +- (CGImageRef)takeViewSnapshotForContentView:(WKContentView *)contentView; I think this should return a RetainPtr as well. > Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm:52 > +@interface WKSwipeInteractiveTransitionDelegate : NSObject <_UINavigationInteractiveTransitionBaseDelegate> This is not a delegate. How about TransitionController?
Tim Horton
Comment 6 2014-02-07 16:42:19 PST
WebKit Commit Bot
Comment 7 2014-02-07 16:45:29 PST
Attachment 223516 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:39: _UIViewControllerTransitionContext is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:40: _UINavigationInteractiveTransitionBase is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 8 2014-02-07 16:49:48 PST
WebKit Commit Bot
Comment 9 2014-02-07 16:51:21 PST
Attachment 223518 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:39: _UIViewControllerTransitionContext is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:40: _UINavigationInteractiveTransitionBase is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 10 2014-02-07 16:53:38 PST
Note You need to log in before you can comment on or make changes to this bug.