Bug 128354 - [WK2] Fitler touch events only based on touch start
Summary: [WK2] Fitler touch events only based on touch start
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-06 18:14 PST by Benjamin Poulain
Modified: 2014-02-07 13:57 PST (History)
1 user (show)

See Also:

Attachments
Patch (5.21 KB, patch)
2014-02-06 18:17 PST, Benjamin Poulain 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-02-06 18:14:31 PST 
[WK2] Fitler touch events only based on touch start
Comment 1 Benjamin Poulain 2014-02-06 18:17:14 PST 
Created attachment 223413 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-02-06 22:58:46 PST 
Comment on attachment 223413 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223413&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1380
> +bool WebPageProxy::shouldTrackTouchEvents(const WebTouchEvent& event)

Odd that the name says "events" but the argument is "event".

Maybe this should be shouldStartTrackingTouchEvents?

The function can be |const|
Comment 3 Benjamin Poulain 2014-02-06 23:39:12 PST 
(In reply to comment #2)
> (From update of attachment 223413 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223413&action=review
> 
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:1380
> > +bool WebPageProxy::shouldTrackTouchEvents(const WebTouchEvent& event)
> 
> Odd that the name says "events" but the argument is "event".
> 
> Maybe this should be shouldStartTrackingTouchEvents?

That is a good point, I like shouldStartTrackingTouchEvents(). I will also rename the argument from "event" to touchStartEvent.
Comment 4 Benjamin Poulain 2014-02-07 13:57:09 PST 
Committed r163645: <http://trac.webkit.org/changeset/163645>