Bug 128351 - [iOS] make should build WebKit2
Summary: [iOS] make should build WebKit2
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2014-02-06 17:50 PST by Joseph Pecoraro
Modified: 2014-02-06 20:06 PST (History)
5 users (show)

See Also:

[PATCH] Proposed Fix (1.00 KB, patch)
2014-02-06 17:51 PST, Joseph Pecoraro
dbates: review+
dbates: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-02-06 17:50:05 PST
This is almost exactly a year old make file change. excluding WebKit2 on iOS. We should include it, build-webkit includes it.
Comment 1 Joseph Pecoraro 2014-02-06 17:51:00 PST
Created attachment 223412 [details]
[PATCH] Proposed Fix
Comment 2 Daniel Bates 2014-02-06 19:55:17 PST
Comment on attachment 223412 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=223412&action=review

> Source/Makefile:-7
> -ifneq (,$(findstring iphoneos,$(SDKROOT)))
> -	MODULES = WTF JavaScriptCore ThirdParty/ANGLE WebCore WebKit
> -else ifneq (,$(findstring iphonesimulator,$(SDKROOT)))
> -	MODULES = WTF JavaScriptCore ThirdParty/ANGLE WebCore WebKit
> -endif

Do we build WebInspectorUI for iOS? If not, then we need to exclude it from the iOS device and simulator builds.
Comment 3 Joseph Pecoraro 2014-02-06 19:58:57 PST
Comment on attachment 223412 [details]
[PATCH] Proposed Fix

Good call! I'll keep these lines and just add WebKit2 to the. Thanks for the review!
Comment 4 Joseph Pecoraro 2014-02-06 20:06:50 PST