Bug 128347 - Workaround REGRESSION(r163195-r163227): Crash beneath NSErrorUserInfoFromJSException when installing AppleInternal.mpkg
Summary: Workaround REGRESSION(r163195-r163227): Crash beneath NSErrorUserInfoFromJSEx...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
Keywords: InRadar
Depends on:
Reported: 2014-02-06 17:23 PST by Michael Saboff
Modified: 2014-02-06 17:58 PST (History)
0 users

See Also:

Patch (4.51 KB, patch)
2014-02-06 17:32 PST, Michael Saboff
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-02-06 17:23:48 PST
The issue is that stack checks are failing when running on a different thread than the thread that created the VM.  Disabling stack checking when we call JavaScript by creating a VM via JSGlobalContextCreate() and JSContextGroupCreate().

Comment 1 Michael Saboff 2014-02-06 17:32:23 PST
Created attachment 223409 [details]
Comment 2 Geoffrey Garen 2014-02-06 17:35:05 PST
Comment on attachment 223409 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=223409&action=review


> Source/JavaScriptCore/ChangeLog:11
> +        Added a flag to VM class called m_ignoreStackLimit that disables stack limit checks.
> +        We set this flag in JSContextGroupCreate() and JSGlobalContextCreateInGroup().
> +
> +        Disabled stack overflow tests in testapi.js since it uses these paths.

You should explain that this is a temporary work-around, which we will remove once we have a proper fix. Otherwise, someone who's not you or me will think that we've removed stack checking from JavaScriptCore, and they will be reasonably alarmed.
Comment 3 Michael Saboff 2014-02-06 17:58:37 PST
Committed r163595: <http://trac.webkit.org/changeset/163595>