Bug 128342 - Remove ChildProcess::m_activeTasks
Summary: Remove ChildProcess::m_activeTasks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-06 16:20 PST by Gavin Barraclough
Modified: 2014-02-06 17:52 PST (History)
0 users

See Also:

Attachments
Fix (14.23 KB, patch)
2014-02-06 16:28 PST, Gavin Barraclough 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-02-06 16:20:35 PST 
Currently we funnel a number of different user activities to a single UserActivity object, which requires a call down from WebCore to WebKit2. Split these out so we can track them separately.
Comment 1 Gavin Barraclough 2014-02-06 16:28:25 PST 
Created attachment 223402 [details]
Fix
Comment 2 Anders Carlsson 2014-02-06 16:30:58 PST 
Comment on attachment 223402 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=223402&action=review

> Source/WebKit2/PluginProcess/PluginProcess.cpp:63
> +    , m_connectionActivity("PluginProcess conection activity.")

Typo conection.

> Source/WebKit2/Shared/ActivityAssertion.h:37
> +    ActivityAssertion(UserActivity&);

I'd make this explicit.
Comment 3 Gavin Barraclough 2014-02-06 17:52:52 PST 
Transmitting file data ...............
Committed revision 163591.