Bug 128333 – Web Inspector: show probe sets for script content views in the details sidebar

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Upstreaming this will include:

ProbeDetailsSidebarPanel
ProbeSetDetailsSection
ProbeSetDataGrid
EventListenerSet

and some glue code to make the sidebar show up at the right times.

[Radar WebKit Bug Importer]

<rdar://problem/16005982>

[Blaze Burg]

Created attachment 223545 [details]
patch - maybe needs new asset instead of PDF glyph

[Timothy Hatcher]

Comment on attachment 223545 [details]
patch - maybe needs new asset instead of PDF glyph

View in context: https://bugs.webkit.org/attachment.cgi?id=223545&action=review

> Source/WebInspectorUI/UserInterface/DataGrid.js:385
> +    insertColumn: function(columnIdentifier, columnData, insertionIndex) {

Some newlines in this function would help readability.

> Source/WebInspectorUI/UserInterface/DataGrid.js:399
> +        console.log("columns ", this.orderedColumns.slice());

Debug statement.

> Source/WebInspectorUI/UserInterface/ProbeSetDataGridNode.js:101
> +            default: console.log("Don't know how to represent sample:", sample);

console.error?

[Blaze Burg]

(In reply to comment #3)
> (From update of attachment 223545 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223545&action=review
> 
> > Source/WebInspectorUI/UserInterface/DataGrid.js:385
> > +    insertColumn: function(columnIdentifier, columnData, insertionIndex) {
> 
> Some newlines in this function would help readability.

I added a few, but the code is already put into 5-line chunks for setting up each DOM element or whatever. Not sure how much more can be split into separate actions.

[Blaze Burg]

Committed r163735: <http://trac.webkit.org/changeset/163735>