Bug 128325 – MathMLTextElement::childShouldCreateRenderer should return false for the mspace element

• Status: RESOLVED
• Resolution: FIXED
• Component: MathML

[Frédéric Wang (:fredw)]

I'm extracting this small change from bug 124838.

The mspace element can not have children, so MathMLTextElement::childShouldCreateRenderer should always return false. Currently it renders true for text node. That should not be a problem since RenderMathMLSpace::isChildAllowed returns false, but let's explicitly prevent children on the content side. I'll also add a regression test to ensure that mspace does not have child renderers.

[Frédéric Wang (:fredw)]

Created attachment 223370 [details]
Patch V1

First try without test reference to get the PNG output.

[Frédéric Wang (:fredw)]

Created attachment 223371 [details]
Patch V1

[Frédéric Wang (:fredw)]

Created attachment 223434 [details]
Patch V2

Trying with the GTK screenshot...

[Build Bot]

Comment on attachment 223434 [details]
Patch V2

Attachment 223434 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5999911136919552

New failing tests:
mathml/presentation/mspace-children.html

[Build Bot]

Created attachment 223445 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 223434 [details]
Patch V2

Attachment 223434 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4960967137951744

New failing tests:
mathml/presentation/mspace-children.html

[Build Bot]

Created attachment 223447 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 223434 [details]
Patch V2

Attachment 223434 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6156317873930240

New failing tests:
mathml/presentation/mspace-children.html

[Build Bot]

Created attachment 223449 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Frédéric Wang (:fredw)]

Created attachment 223451 [details]
Patch V3

Now trying with Mac's expected text output.

[chris fleizach]

Comment on attachment 223451 [details]
Patch V3

View in context: https://bugs.webkit.org/attachment.cgi?id=223451&action=review

> Source/WebCore/ChangeLog:9
> +        childShouldCreateRenderer always returns false.

always "return" false

[Frédéric Wang (:fredw)]

Created attachment 223461 [details]
Patch (final version)

[WebKit Commit Bot]

Comment on attachment 223461 [details]
Patch (final version)

Clearing flags on attachment: 223461

Committed r163626: <http://trac.webkit.org/changeset/163626>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.